[Be-devel] HTML-generation bug with nested comments

[Owen Jacobson]

Hi there,

It looks like the <div> elements used to indent nested comments don't get closed properly with either 1.1.1 or this evening's master revision (ec2f5d26). Top-level comments following a series of nested comments are rendered as siblings of the last nested comment, instead of all the way to the right.

This does not affect 'be show'.

I reproduced this with the bug below; I can also provide the .be tree as a tarball.

-o

-- begin output --
$ be show c7dbf279/c9ebdac6
ID : c9ebdac6-a314-4309-8cf6-747b95de889a
Short name : c7d/c9e
Severity : minor
Status : open
Assigned :
Reporter : Owen Jacobson <owen at example.com>
Creator : Owen Jacobson <owen at example.com>
Created : Tue, 12 Mar 2013 20:10 (Wed, 13 Mar 2013 00:10:43 +0000)
Frobnicate everything
--------- Comment ---------
Name: c7d/c9e/b7b
From: Owen Jacobson <owen at example.com>
Date: Wed, 13 Mar 2013 00:16:23 +0000

I dunno, man.
--------- Comment ---------
Name: c7d/c9e/385
From: Owen Jacobson <owen at example.com>
Date: Wed, 13 Mar 2013 00:17:21 +0000

WHAT>
--------- Comment ---------
Name: c7d/c9e/7b4
From: Owen Jacobson <owen at example.com>
Date: Wed, 13 Mar 2013 00:29:29 +0000

More nesting!
--------- Comment ---------
Name: c7d/c9e/a12
From: Owen Jacobson <owen at example.com>
Date: Wed, 13 Mar 2013 00:17:14 +0000

I should be top-level, but the HTML shows me as a sibling of c7d/c9e/7b4.

[W. Trevor King]

Post by Owen Jacobson
It looks like the <div> elements used to indent nested comments
don't get closed properly with either 1.1.1 or this evening's master
revision (ec2f5d26).

Thanks for the report, Owen. Does my fix in f41908a work for you?

Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://void.printf.net/pipermail/be-devel/attachments/20130312/10260697/attachment.pgp>

[Owen Jacobson]

Post by W. Trevor King

Post by Owen Jacobson
It looks like the <div> elements used to indent nested comments
don't get closed properly with either 1.1.1 or this evening's master
revision (ec2f5d26).

Thanks for the report, Owen. Does my fix in f41908a work for you?

Verified. c7d/c9e/a12 from my example is now rendered at the left margin, as it should be.

Thanks for the quick turnaround!

-o